fix: ensure that VimsImageProcessor#write_to_jpeg writes jpg #40
+40
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vips determines file format using the extension taken from the target filename. That makes
VipsImageProcessor#write_to_jpeg
's behaviour misleading for names with a different extension (egimage.png
) and broken for names with no extension (egtmp123413123
). Example error message:Solution
Write to file with
.jpg
extension, then rename to target filenameNotes
context
instead ofdescribe
where it felt appropriate